If you do the Default builds for a CPU you won't encounter this bug
since Default doesn't contain a hyphen. So the nightlies don't hit it.
You only hit it when you build for an individual platform.

I suspect the problem is where the config symbols are getting parsed.
CONFIG_TARGET_ramips_rt305x_AWM002EVB=y  parses ok
CONFIG_TARGET_ramips_rt305x_AWM002-EVB=y  fails with a blank $PROFILE

I don't understand the Makefiles well enough to find where this parsing happens.

On Tue, Sep 3, 2013 at 8:11 AM, jonsm...@gmail.com <jonsm...@gmail.com> wrote:
> Any ideas on what is up with hyphen processing in target names? I had
> to make these changes to get AsiaRF working again.
>
> diff --git a/target/linux/ramips/base-files/lib/ramips.sh
> b/target/linux/ramips/base-files/lib/ramips.sh
> index 066f3bd..f494e79 100755
> --- a/target/linux/ramips/base-files/lib/ramips.sh
> +++ b/target/linux/ramips/base-files/lib/ramips.sh
> @@ -46,7 +46,7 @@ ramips_board_detect() {
>   *"Argus ATP-52B")
>   name="argus-atp52b"
>   ;;
> - *"AsiaRF AWM002-EVB")
> + *"AsiaRF AWM002 EVB")
>   name="awm002-evb"
>   ;;
>   *"BR6524N")
> diff --git a/target/linux/ramips/image/Makefile
> b/target/linux/ramips/image/Makefile
> index 2891aaf..339def1 100644
> --- a/target/linux/ramips/image/Makefile
> +++ b/target/linux/ramips/image/Makefile
> @@ -319,7 +319,7 @@ define BuildFirmware/ASL26555/initramfs
>  endef
>  Image/Build/Profile/ASL26555=$(call
> BuildFirmware/ASL26555/$(1),$(1),asl26555,ASL26555)
>
> -Image/Build/Profile/AWM002-EVB=$(call
> BuildFirmware/DefaultDualSize/$(1),$(1),awm002-evb,AWM002-EVB)
> +Image/Build/Profile/AWM002EVB=$(call
> BuildFirmware/DefaultDualSize/$(1),$(1),awm002-evb,AWM002-EVB)
>
>  Image/Build/Profile/BC2=$(call BuildFirmware/Default8M/$(1),$(1),bc2,BC2)
>
> @@ -499,7 +499,7 @@ define Image/Build/Profile/Default
>   $(call Image/Build/Profile/ALL5003,$(1))
>   $(call Image/Build/Profile/ARGUS_ATP52B,$(1))
>   $(call Image/Build/Profile/ASL26555,$(1))
> - $(call Image/Build/Profile/AWM002-EVB,$(1))
> + $(call Image/Build/Profile/AWM002EVB,$(1))
>   $(call Image/Build/Profile/BC2,$(1))
>   $(call Image/Build/Profile/BROADWAY,$(1))
>   $(call Image/Build/Profile/CARAMBOLA,$(1))
> diff --git a/target/linux/ramips/rt305x/profiles/asiarf.mk
> b/target/linux/ramips/rt305x/profiles/asiarf.mk
> index aa25db5..8b1f757 100644
> --- a/target/linux/ramips/rt305x/profiles/asiarf.mk
> +++ b/target/linux/ramips/rt305x/profiles/asiarf.mk
> @@ -5,14 +5,14 @@
>  # See /LICENSE for more information.
>  #
>
> -define Profile/AWM002-EVB
> +define Profile/AWM002EVB
>   NAME:=AsiaRF AWM002-EVB
>   PACKAGES:=kmod-usb-core kmod-usb-ohci kmod-usb2 kmod-ledtrig-usbdev \
>   kmod-i2c-core kmod-i2c-gpio
>  endef
>
> -define Profile/AWM002-EVB/Description
> +define Profile/AWM002EVB/Description
>   Package set for AsiaRF AWM002 Evaluation Board
>  endef
>
> -$(eval $(call Profile,AWM002-EVB))
> +$(eval $(call Profile,AWM002EVB))
>
> On Mon, Sep 2, 2013 at 5:04 PM, jonsm...@gmail.com <jonsm...@gmail.com> wrote:
>> Something seems to be wrong in the Makefile when parsing target profiles
>> with hyphens in them.
>>
>> For example: TARGET_ramips_rt305x_RT-N13U
>> $(PROFILE) ends up blank instead of RT-N13U
>>
>> I searched around and can't figure out where this parsing is happening.
>>
>> --
>> Jon Smirl
>> jonsm...@gmail.com
>
>
>
> --
> Jon Smirl
> jonsm...@gmail.com



-- 
Jon Smirl
jonsm...@gmail.com
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Reply via email to