On Mon, Aug 19, 2013 at 04:49:37PM -0700, Daniel Gimpelevich wrote:
> On Tue, 2013-08-20 at 01:30 +0200, Luka Perkov wrote: 
> > Hi Daniel,
> > 
> > Please update your patches with better commit message. It should also
> > contain links to the mailing list and/or patchwork where the patch was
> > sent (if possible of course).
> > 
> > Also, patches inside generic should have very detailed description. This
> > is not the case for many patches at the moment but I plan to work on
> > this in the (near) future.
> > 
> > Take a look at the links bellow for an example:
> > 
> > https://dev.openwrt.org/changeset/37808
> > https://dev.openwrt.org/browser/trunk/target/linux/generic/patches-3.10/470-mtd_m25p80_add_pm25_flash_support.patch
> > 
> > Luka
> 
> This could actually be taken straight from my upstream submission:
> https://patchwork.kernel.org/patch/2846700/

Or you could resend the patch.

Luka
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Reply via email to