On Tue, Jul 23, 2013 at 2:10 AM, jonsm...@gmail.com <jonsm...@gmail.com> wrote: > On Mon, Jul 22, 2013 at 6:00 PM, Jonas Gorski <j...@openwrt.org> wrote: >> On Mon, Jul 22, 2013 at 9:38 PM, John Crispin <j...@phrozen.org> wrote: >>> On 22/07/13 21:37, jonsm...@gmail.com wrote: >>>> >>>> Here's a photo - you can see how it is a module mounted on a baseboard. >>>> http://www.ayyari.com/pic/AYYAR.jpg >>> >>> >>> these 2 file have essentially the same info in them which made me wonder, >>> but i understand now why this is so ... >>> >>> target/linux/ramips/dts/AWM002-EVB-4M.dts >>> target/linux/ramips/dts/AWM002-EVB-8M.dts >>> >>> >>> i am not really happy with having 5 dts files to essentially describe one >>> biard, but unless i can come up with a better solution tomorrow i will merge >>> the patch as is. >> >> Since both are identical except for the part they include, everything >> in them could be moved into the "top" dtsi, and the dtsi files with >> the flashchip made to .dts. >> >> Also somehow the one other thing that should be different between the >> two versions, the firmware partion's size, is defined for the top >> .dtsi; that one should actually be in the .dts files. >> >> Looking at it, it is defined as ~32 MiB, so there is some reliance on >> the kernel doing the right thing and shrinking it to the right size. >> And if we are doing that, then there is no reason at all anymore for >> having different dtsi files, as we can then also use m25p80's ability >> to autodetect the flash chip and get rid of the dual size thingy. > > I'm happy with whatever we pick, it isn't hard to edit them. > > How about this... > AWM002.dtsi -- the module (with m25p80 flash specified) > AWM002-EVB.dtsi -- the baseboard
Is there a specific reason why you can't merge these two? > AWM002-EVB-4M.dts -- these include the first two and add the specific > flash flash chip > AWM002-EVB-8M.dts > > Where do the partitions go? The dts files? Yes. Jonas _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
