Hello!
This is a reply regarding the previous email from danitool for the HW556.
> Nice, I didn't notice the LAN leds were controled by GPIOs, and bicolor!!.
>
> However are you aware the GPIO 6 is used to swith on/off all leds?. I
> defined it originally with my first messy patch since without it the leds
> at the front of the case didn't work, and it provides extra functionality
> for controlling those leds.
>
Yes, in fact I just found out that the GPIO 6 can be used for the
aforementioned purpose but only with HW556C and B hardware. Hence, I
am letting go of the assignment in the HW556A. I currently have both
HW556A and HW556C, so I can confirm this.
> About current GPIOs assignments they are all correct, and checked several
> times by Noltari, me and probably other people.
>
> ++ .name = "HW556:red:message",
> ++ .gpio = 12,
> ++ .active_low = 1,
>
> This isn't correct, Shouldn't it be HW556:green:lan1?
The section you were quoting is actually for the HW556A. Again,
regarding the pin assignments on HW556A, some are not exactly right.
You can check and confirm this by flashing the current trunk build and
setting the leds. Setting the message led turns on the LAN1 one
instead of the actual message led, and similarly the hspa one turns on
the LAN2 leds.
Anyway, below is a revised patch for the platform.
Signed-off-by: Angga Reza Fardana
---
diff --git a/target/linux/brcm63xx/patches-3.8/534-board_hw556.patch
b/target/linux/brcm63xx/patches-3.8/534-board_hw556.patch
index fb0afa4..5280a31 100644
--- a/target/linux/brcm63xx/patches-3.8/534-board_hw556.patch
+++ b/target/linux/brcm63xx/patches-3.8/534-board_hw556.patch
@@ -1,6 +1,6 @@
--- a/arch/mips/bcm63xx/boards/board_bcm963xx.c
+++ b/arch/mips/bcm63xx/boards/board_bcm963xx.c
-@@ -2856,6 +2856,374 @@ static struct board_info __initdata boar
+@@ -2856,6 +2856,488 @@ static struct board_info __initdata boar
},
};
@@ -122,12 +122,12 @@
+
+ .leds = {
+ {
-+ .name = "HW556:red:message",
++ .name = "HW556:green:lan1",
+ .gpio = 0,
+ .active_low = 1,
+ },
+ {
-+ .name = "HW556:red:hspa",
++ .name = "HW556:green:lan2",
+ .gpio = 1,
+ .active_low = 1,
+ },
@@ -143,10 +143,44 @@
+ .default_trigger = "default-on",
+ },
+ {
-+ .name = "HW556:red:all",
-+ .gpio = 6,
++ .name = "HW556:red:message",
++ .gpio = 12,
++ .active_low = 1,
++ },
++ {
++ .name = "HW556:red:lan1",
++ .gpio = 13,
++ .active_low = 1,
++ },
++ {
++ .name = "HW556:red:hspa",
++ .gpio = 15,
++ .active_low = 1,
++ },
++ {
++ .name = "HW556:red:lan2",
++ .gpio = 22,
++ .active_low = 1,
++ },
++ {
++ .name = "HW556:green:lan3",
++ .gpio = 23,
++ .active_low = 1,
++ },
++ {
++ .name = "HW556:red:lan3",
++ .gpio = 26,
++ .active_low = 1,
++ },
++ {
++ .name = "HW556:green:lan4",
++ .gpio = 27,
++ .active_low = 1,
++ },
++ {
++ .name = "HW556:red:lan4",
++ .gpio = 28,
+ .active_low = 1,
-+ .default_trigger = "default-on",
+ },
+ },
+
@@ -241,6 +275,46 @@
+ .active_low = 1,
+ .default_trigger = "default-on",
+ },
++ {
++ .name = "HW556:green:lan1",
++ .gpio = 12,
++ .active_low = 1,
++ },
++ {
++ .name = "HW556:red:lan1",
++ .gpio = 13,
++ .active_low = 1,
++ },
++ {
++ .name = "HW556:green:lan2",
++ .gpio = 15,
++ .active_low = 1,
++ },
++ {
++ .name = "HW556:red:lan2",
++ .gpio = 22,
++ .active_low = 1,
++ },
++ {
++ .name = "HW556:green:lan3",
++ .gpio = 23,
++ .active_low = 1,
++ },
++ {
++ .name = "HW556:red:lan3",
++ .gpio = 26,
++ .active_low = 1,
++ },
++ {
++ .name = "HW556:green:lan4",
++ .gpio = 27,
++ .active_low = 1,
++ },
++ {
++ .name = "HW556:red:lan4",
++ .gpio = 28,
++ .active_low = 1,
++ },
+ },
+
+ .buttons = {
@@ -334,6 +408,46 @@
+ .active_low = 1,
+ .default_trigger = "default-on",
+ },
++ {
++ .name = "HW556:green:lan1",
++ .gpio = 12,
++ .active_low = 1,
++ },
++ {
++ .name = "HW556:red:lan1",
++ .gpio = 13,
++ .active_low = 1,
++ },
++ {
++ .name = "HW556:green:lan2",
++ .gpio = 15,
++ .active_low = 1,
++ },
++ {
++ .name = "HW556:red:lan2",
++ .gpio = 22,
++ .active_low = 1,
++ },
++ {
++ .name = "HW556:green:lan3",
++ .gpio = 23,
++ .active_low = 1,
++ },
++ {
++ .name = "HW556:red:lan3",
++ .gpio = 26,
++ .active_low = 1,
++ },
++ {
++ .name = "HW556:green:lan4",
++ .gpio = 27,
++ .active_low = 1,
++ },
++ {
++ .name = "HW556:red:lan4",
++ .gpio = 28,
++ .active_low = 1,
++ },
+ },
+
+ .buttons = {
@@ -375,7 +489,7 @@
/* T-Home Speedport W 303V Typ B */
static struct board_info __initdata board_spw303v = {
.name = "96358-502V",
-@@ -3284,6 +3652,10 @@ static const struct board_info __initcon
+@@ -3284,6 +3766,10 @@ static const struct board_info __initcon
&board_nb4_fxc_r2,
&board_ct6373_1,
&board_HW553,
@@ -386,7 +500,7 @@
&board_spw303v,
&board_DVAG3810BN,
#endif
-@@ -3349,13 +3721,37 @@ static void __init boardid_fixup(u8 *boo
+@@ -3349,13 +3835,37 @@ static void __init boardid_fixup(u8 *boo
struct bcm_tag *tag = (struct bcm_tag *)(boot_addr + CFE_OFFSET_64K);
char *board_name = (char *)bcm63xx_nvram_get_name();
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
