On 04/24/2013 11:53 PM, Etienne Champetier wrote:
> Hi
Hello Etienne,
> Index: admin/zabbix/files/zabbix_extra_mac80211.init
> ===================================================================
> --- admin/zabbix/files/zabbix_extra_mac80211.init (révision 0)
> +++ admin/zabbix/files/zabbix_extra_mac80211.init (révision 0)
> @@ -0,0 +1,9 @@
> +#!/bin/sh /etc/rc.common
> +# Copyright (C) 2008-2011 OpenWrt.org
> +
> +START=59
> +
> +start() {
> + chmod -R a+r /sys/kernel/debug/ieee80211/*/statistics/
> +}
> +
I'm sorry, but I still don't think that's the way to go.
That's not just a theoretical issue - one just can't keep track of those
changes made.
If packages start to modify filesystem permissions, this will result in
just a mess (incompatibilities between packages, race-conditions,
security-issues, and probably much more).
I appreciate your work, but I won't commit a patch which results in a
package modifying the permissions of files outside its scope.
Maybe it makes sense to globally change the permissions of
/sys/kernel/debug/ieee80211/*/statistics/ to be world-readable.
However I'll let that to the other devs, since I don't know about what
kind of possibly sensitive information this debug interface exposes.
Cheers
mirko
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
