On 2013-05-14 3:13 PM, Andrew McDonnell wrote: > Hi Felix, > > Sorry, I'm still learning how this project works ... I have been trying to > follow the patch submission checklist as best I can. > > Perhaps that adivce could be added to the guidelines on > https://dev.openwrt.org/wiki/SubmittingPatches page, but I only worked out how > to get edit access to other wiki http://wiki.openwrt.org/. Do you know where > I can propose changes to the dev wiki? > > (I was confusing for quite a while when I started, being there is a forum and > two wikis and a mailing list...) > > I think of the patches I have submmited just now, the MTD and the ring size > are the only ones directly copied as such What I mentioned is a general development issue that doesn't really fit well into the SubmittingPatches howto. In general you should not submit changes that are unnecessary and/or not well understood. I wasn't objecting to copying stuff from DD-WRT per se, but more about copying stuff from it without understanding it or knowing if it helps at all. I'm pretty sure that the MTD kernel config changes are wrong and not needed for bringing up your board.
- Felix _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
