Hi Sandy,
On Mon, Apr 29, 2013 at 11:00:00PM -0400, Sandy McArthur Jr wrote:
> tinc expects long parameters to be in the form "--name=value" and the
> current init scripts generate "--name value" parameters.
I don't think that matters. Also look bellow...
>+++ b/net/tinc/files/tinc.init
>@@ -42,7 +42,7 @@ append_params() {
> config_get v "$s" "$p"
> IFS="$LIST_SEP"
> for v in $v; do
>- [ -n "$v" ] && append_param "$p" && ARGS="$ARGS $v"
>+ [ -n "$v" ] && append_param "$p" && ARGS="$ARGS=$v"
If we are going to nitpick I would say it should be done like this:
[ -n "$v" ] && append_param "$p" && ARGS="$ARGS=\"$v\""
> done
> unset IFS
> done
Luka
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
