On 2013-03-11 7:58 PM, Petr Štetiar wrote:
> Petr Štetiar <yn...@true.cz> [2013-03-10 21:21:04]:
> 
>> Felix Fietkau <n...@openwrt.org> [2013-03-10 15:37:41]:
>> 
>> > Does reverting this change make things work for you in the latest revision?
>> 
>> Yes, I did reverted it in AA and it works fine:
>> 
>>      89b3ea101c0a49194d637a119bccea6ae47ae2c3 Revert "AA: ar71xx: fix GPIO 
>> function selection for AR934x"
>>      9fbae55e5eba290bdf4fa47ad75c998da9d4931e ar71xx: enable building 
>> ramdisk images for WZRHPG30XNH board types
>>      4577d9d123ae4ca097c75f5ce2f4344ce67b2074 AA: hotplug2: restore 
>> accidentally deleted patch
>>      ...
> 
> This call in om2p_hs_setup() is causing this:
> 
>       ath79_gpio_function_enable(AR933X_GPIO_FUNC_JTAG_DISABLE);
Interesting. The commit enabled access to the gpio function register for
AR934x, but that register has a different layout than the ones on older
chips. This line of code (which previously did nothing, as it touched
the wrong register) sets a bit that maps to a 'reserved' flag according
to hardware documentation.
As a quick fix we can just get rid of the line (it never did anything
useful anyway), and then we should probably check if the GPIO function
register access should be common for AR934x and pre-AR934x at all, given
that they don't seem to have much in common.
Maybe Gabor (Cc'd) has an opinion on that...

Thanks for tracking this down.

- Felix
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to