Hello, comments below to improve your patch:
Dne 12.2.2013 17:42, Infactum napsal(a): > Patch adds chan_dongle Asterisk 11 channel driver for Huawei UMTS/3G USB > modems (dongles). > + > +WITH_ASTERISK=asterisk-11.2.1 Follow CFLAGS comment below - this variable is unnecessary. With each version bump this Makefile would need to be also updated. Solution below solves updating asterisk11 without letting this package being outdated by a simple version bump. > + > +include $(INCLUDE_DIR)/package.mk > + > +define Package/asterisk11-chan-dongle > + SUBMENU:=Telephony > + SECTION:=net > + CATEGORY:=Network > + URL:=http://www.asterisk.org/ > + MAINTAINER:=Hans Zandbelt <hans.zandb...@gmail.com> I suppose that maintainer should add MAINTAINER variable himself. Currently Hans Zandbelt does not maintain asterisk package anymore, so this variable should not be set at all for this package. > + DEPENDS:= asterisk11 +libiconv-full > + TITLE:=Huawei UMTS 3G dongle support > +endef > + > +define Package/asterisk11-chan-dongle/description > + Asterisk channel driver for Huawei UMTS 3G dongle > +endef It would be nice to remove this indentation. If you take a look at the package description in the 'make menuconfig', there's unnecessary gap. > + > +MAKE_ARGS:= \ > + CC="$(TARGET_CC)" \ > + LD="$(TARGET_CC)" \ > + CFLAGS="$(TARGET_CFLAGS) -DASTERISK_VERSION_NUM=110000 -DLOW_MEMORY > -D_XOPEN_SOURCE=600 $(TARGET_CPPFLAGS) > -I$(STAGING_DIR)/usr/lib/libiconv-full/include > -I$(BUILD_DIR)/$(WITH_ASTERISK)/include -DHAVE_CONFIG_H -I. -fPIC" \ -I$(STAGING_DIR)/usr/include/asterisk-11/include/ > + LDFLAGS="$(TARGET_LDFLAGS) -L$(STAGING_DIR)/usr/lib/libiconv-full/lib > -liconv" \ > + DESTDIR="$(PKG_INSTALL_DIR)/usr/lib/asterisk/modules" > + > +define Build/Configure > + $(call Build/Configure/Default, \ > + --with-asterisk=$(BUILD_DIR)/$(WITH_ASTERISK)/include \ --with-asterisk should point to STAGING_DIR - for package asterisk11 it should be (if you take a look at InstallDev macro at asterisk11's Makefile): --with-asterisk=$(STAGING_DIR)/usr/include/asterisk-11/include/ ~ Jiri Slachta _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
