b53_switch_detect returns value returned by b53_read8, which is 0 for
success. So fail (and return error) only if b53_switch_detect returned
something else than 0. This fixes supported and advertising being zeros
for MDIO access.

Cc: Jonas Gorski <j...@openwrt.org>
Signed-off-by: Rafał Miłecki <zaj...@gmail.com>
---
 target/linux/generic/files/drivers/net/phy/b53/b53_mdio.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/linux/generic/files/drivers/net/phy/b53/b53_mdio.c 
b/target/linux/generic/files/drivers/net/phy/b53/b53_mdio.c
index 9283af60..1ba0591 100644
--- a/target/linux/generic/files/drivers/net/phy/b53/b53_mdio.c
+++ b/target/linux/generic/files/drivers/net/phy/b53/b53_mdio.c
@@ -267,7 +267,7 @@ static int b53_phy_probe(struct phy_device *phydev)
        mutex_init(&dev.reg_mutex);
 
        ret = b53_switch_detect(&dev);
-       if (!ret)
+       if (ret)
                return ret;
 
        if (is5325(&dev) || is5365(&dev))
-- 
1.7.10.4

_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to