On 2012-12-24 3:46 PM, Stefan Hellermann wrote: > I wanted to use some statistics from /sys/kernel/debug/ieee80211, > so I enabled PACKAGE_MAC80211_DEBUGFS. But I could not use it, > because CONFIG_KERNEL_DEBUG_FS was not set and it's a little bit > hidden. After manually setting CONFIG_KERNEL_DEBUG_FS to y, > everything was fine. This patch automatically selects > CONFIG_KERNEL_DEBUG_FS if PACKAGE_MAC80211_DEBUGFS is set. > > Additionally, the help text says "Say N unless you know you need this.", > but it's set to default y. I removed the default y to be consistent > with the help text. It's better to remove this note from the help text (which was probably copied from the kernel's Kconfig). Keep the default at y, debugfs support is very useful for getting additional status information about the state of wireless.
Also, please move the select to the 'config PACKAGE_MAC80211_DEBUGFS' symbol, so you can drop the 'if PACKAGE_MAC80211_DEBUGFS' part. - Felix _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
