On Mon, 31 Dec 2012 15:04:58 +0100, Bastian Bittorf wrote: > this is only correct in the short run. > maybe OpenWrt will switch to toybox later.
We should deal with that if and when it happens. > i understand the examples and the problem. > it is possible to configure busybox wget to behave like GNU wget > with CONFIG_FEATURE_WGET_AUTHENTICATION=y but i dont like the idea to > bloat the default config by simply switching it on. How would this be adding bloat to the default config? BUSYBOX_CONFIG_FEATURE_WGET_AUTHENTICATION is already default=y. > so we have to diff > between both characteristics. sadly, there seems to be no good way > to distinguish between the wget versions, so i propose this: > > if wget --version 2>/dev/null | grep -q ^"GNU" ; then > # user --user=... --pass=... > else > # do it the simply way > fi This is over-engineered. We are dealing with embedded devices here using single-core Atheros/Broadcom chips, not octa-core Intel Xeon chips. IMHO, we provide the GNU versions of tools as a help for our users. We should however, be able to depend on BusyBox as the default, and always available shell. If we need to go down the road of slowing ddns-scripts with a check for GNU Wget, it would be much faster to simply test if "/usr/bin/wget" is a symlink, and append "--no-http-keep-alive" to $retrieve_prog accordingly. Jon
signature.asc
Description: Digital signature
_______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
