On 2012-12-31 7:38 PM, Robert Bradley wrote:
> Cumulative patch for avoiding unaligned access traps on ar71xx hardware
> using the
> AG71xx network driver and the Linux 3.7.1 kernel. This patch contains
> OpenWRT's existing
> 902-unaligned_access_hacks.patch plus additional modifications from
> CeroWRT. The result
> is a significant increase in performance with both IPv4 and IPv6 traffic.
>
> This is an update of the previous patch at
> http://patchwork.openwrt.org/patch/2147/.
>
> (Note: I use __get_unaligned_cpu32() in this code since it mirrors the
> existing pointer
> dereference better than using __get_unaligned_be32() would.)
>
> Signed-off-by: Robert Bradley <robert.bradl...@gmail.com>
Line wrapping in this patch is badly damaged.
Why did you add __packed in if_vlan.h and flow_keys.h? That part looks
wrong to me.
Also, please double-check the places where you added
__attribute__((aligned(2))) where the struct was already marked as
packed. I'm not sure a 2-byte alignment is guaranteed for ip/tcp/...
option fields, so better leave those alone.
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
