Hi, > -The "wifi" package should also work with broadcom-wl and madwifi, where the > "mac80211" is only for mac80211. I split up to put dependencies, and in case > someone want to make "extra-madwifi" later... > We can make only one package we just have to be sure that the discovery rules > fails gracefully (i think it's the case for mac80211) and explain the > dependencies in the files and not put them in the makefile. (you ask for the > depencies in the first place)
I like the subpackages with dependencies, as I could add my own ones in future. I asked about the depencies because I tried the rules and not a single one worked out of the box. I could figure it out, but people don't RTFM. I tried it on a ar71xx, tp-link tl-wr741-v2. > > -for the startup script i will stop using chown/zabbix user and only make a > chmod +r. I don't want to run zabbix as root. The chmod -R +r /var/state (2 > startup scripts) isn't needed if we correct uci to give the same right for > files in /var/state as in /etc/config (but i haven't looked into). That would be fine for me. Longterm we could ask the uci guys to make the /var/state folder world readable, then we can remove the startup scripts. Good solution as I don't like so many startup scripts. They slow down the startup of the box. I don't know what to do with /sys/kernel/debug/ieee80211. Could you change the startup script to only "chmod o+r /sys/kernel/debug/ieee80211/*/statistics" ? Then the other things like /sys/kernel/debug/ieee80211/*/keys/* are not world readable. > > -lua is doing all the parsing for me, and i always put luci, so it's not a > dependency for me. Can you check the size of all lua dependencies that i add, > i think it's rather small. (can't check right now) I should have done that earlier. I compiled an image with libuci-lua, liblua and lua and it grow only by 60kByte (squashfs image), so I don't mind. Maybe the DEPENDS should be: zabbix-extra-mac80211: +zabbix-agentd +MAC80211_DEBUGFS zabbix-extra-network: +zabbix-agentd +libuci-lua +lua zabbix-extra-wifi: +zabbix-agentd +libiwinfo-lua +libuci-lua libuci-lua does not depend on lua, so I added it. libiwinfo-lua depends on it already, so it's not needed in the wifi case. I will send a Patch to add +lua to libuci-lua, then we can remove it here. MAC80211_DEBUGFS is only usable with CONFIG_KERNEL_DEBUG_FS, so I will send a patch to correct that, too. In the meantime you could add this to the zabbix Makefile, but I don't really like it: define Package/zabbix-extra-mac80211/config select KERNEL_DEBUG_FS endef I hope I don't annoy you with my dependencies :-) > > -the idea of the netowrt.discovery is: monitor only relevant iface (like > br-lan and not eth0.1 and wlan0), and have cool name on the graphs (like wan > instead of eth0.0, or vpn instead of tap99) Ah, that's a good reason. Could you fix it somehow, so that wifi devices are listed for br-lan? I will reply shortly to your other mail. Thanks for your patience, and Joyeux Noël! Stefan _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
