On Mon, 2012-08-13 at 15:06 +0200, Florian Fainelli wrote: > On Thursday 26 April 2012 16:44:02 Abaakouk Mehdi wrote: > > RESENT: Updated patch with last remarks fixed > > > > > > Makefile and patch for package NUT 2.6.3 > > > > Signed-off-by: Mehdi Abaakouk <sil...@sileht.net> > > I do not see any drivers in menuconfig with your Makefile. I would suggest > doing > the following instead: > > - make the driver macro self-contained, such that it also does the call to > BuildPackage > - rename this macro to BuildDriver for instance and get rid of the foreach > since it can be error prone with respect to escaping make variables
As discussed on IRC, adding BuildPackage directly into the driver macro doesn't work. It has to be done separately in a second pass. Which means either you hard-code the list of drivers twice, or you use foreach. In fact, I don't want *us* to hard-code the list of drivers even once. I've changed things a little so that we literally cut and paste the text from nut's own drivers/Makefile.am with the driver lists. That way when we update to a new version of nut, it's simple enough to update the driver list too. I personally wouldn't have bothered with the 'nice' driver descriptions, but I certainly didn't want to rip them out once Mehdi had gone to the trouble of adding them. So I've done that, and I've made it *fail* to build if you add a driver without a description. We might as well be consistent. I've also updated to 2.6.5 and added the OpenUPS driver, which was merged into nut since that release. It could do with a little more work, ideally. We should have an initscript which generates the config files (like ups.conf) in tmpfs automatically from uci config. There's an example of this in the snmpd package. But I certainly wouldn't suggest that it shouldn't be merged until that's done. I'll send my current version of the patch in a few moments... -- dwmw2
smime.p7s
Description: S/MIME cryptographic signature
_______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
