On Monday 12 November 2012 20:50:27 Daniel Golle wrote: > I don't think its actually used anywhere, but GCC supports generating code for > it, both explicitely and also by using the generic vector extension. > I carried this around in my tree for a while and it at least didn't cause any > trouble so far.
I am not against enabling them, but then we are creating an ABI incompatibility if someone, by mistake uses the ramips packages on a platform which happens to be mips32r1 or mips32r2 but without DSP. As far as I can tell, there is no in-kernel emulator for these, so this will just crash the application. It does not seem to me like GCC is able to convert types from plain integers to vectors unless explicitely being told to do so, which means these two flags will be a no-op on the generated code. > And I got no idea if Rt288x comes with MIPS DSP ASE. Did you check /proc/cpuinfo? If we don't override it in cpu-features.h, this should be auto-detected by the kernel. > > Signed-off-by: Daniel Golle <dgo...@allnet.de> > --- > target/linux/ramips/rt305x/target.mk | 1 + > target/linux/ramips/rt3883/target.mk | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/target/linux/ramips/rt305x/target.mk > b/target/linux/ramips/rt305x/target.mk > index 2c78756..a403d26 100644 > --- a/target/linux/ramips/rt305x/target.mk > +++ b/target/linux/ramips/rt305x/target.mk > @@ -4,6 +4,7 @@ > > SUBTARGET:=rt305x > BOARDNAME:=RT305x based boards > +CFLAGS+= -mdsp > > define Target/Description > Build firmware images for Ralink RT305x based boards. > diff --git a/target/linux/ramips/rt3883/target.mk > b/target/linux/ramips/rt3883/target.mk > index 590bb98..0d27ba1 100644 > --- a/target/linux/ramips/rt3883/target.mk > +++ b/target/linux/ramips/rt3883/target.mk > @@ -4,6 +4,7 @@ > > SUBTARGET:=rt3883 > BOARDNAME:=RT3662/RT3883 based boards > +CFLAGS+= -mdspr2 > > define Target/Description > Build firmware images for Ralink RT3662/RT3883 based boards. > -- > 1.8.0 > _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
