Here comes my comments for my package:
Dne 17.11.2012 11:35, Jiri Slachta napsal(a):
> Hello,
> 
> sorry for the duplicity.
> ...
> +AST_MODULES:=

This variable will be removed, it's not used

> +$(eval $(call BuildAsteriskModule,cdr,Provide CDR,Call Detail 
> Record,asterisk11 
> +PACKAGE_asterisk11-mysql:libmysqlclient,/etc/asterisk/cdr.conf 
> /etc/asterisk/cdr_custom.conf /etc/asterisk/cdr_manager.conf 
> /etc/asterisk/cdr_odbc.conf /etc/asterisk/cdr_pgsql.conf 
> /etc/asterisk/cdr_tds.conf,*cdr*,*cdr*,))

I suppose asterisk11-cdr should be split into several modules, there are cdr 
dependencies to mysql, postgres, sqlite - so I think basic cdr package with a 
few additional packages, e.g. asterisk11-cdr-mysql, should be ok.

One thing that bothers me, is quite huge number of asterisk packages. It would 
deserve more sectioning, like:

Add-ons -->
Applicationg -->
Bridging modules -->
Channel Drivers -->
PBX modules -->
Utilities -->
..

The last thing is to enable LOW MEMORY compile flag, it seems to be built 
without it.

I am all ears to any review, any comments to asterisk package. It's an 
essential package for IP telephony, so it would be nice to have the latest LTS 
version of it.
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to