Hi,

On 6 August 2012 20:00, Álvaro Fernández Rojas <nolt...@gmail.com> wrote:
> Add Sagem F@ST2604 board support.
>
> Signed-off-by: Álvaro Fernández Rojas<nolt...@gmail.com>

please use tabs instead of spaces for indentation, apart from that it
looks mostly fine.

>
> Index: target/linux/brcm63xx/base-files/etc/uci-defaults/network
> ===================================================================
> --- target/linux/brcm63xx/base-files/etc/uci-defaults/network
> +++ target/linux/brcm63xx/base-files/etc/uci-defaults/network

Same comment regaring -p1.

> @@ -17,6 +17,7 @@
>  96328avng |\
>  963281TAN |\
>  96348A-122 |\
> +"F@ST2604" |\

Hm, can you put it in alphabetical order ...

>  96358-502V |\
>  CT6373-1 |\

 ... even if it's screwed currently it up? (we'll have to fix that
eventually - currently it's small enough for now).

>  AW4339U |\



Jonas
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to