On 12-08-15 01:28 AM, Edy Corak wrote:
> Index: files/lsm_script
> ===================================================================
> --- files/lsm_script  (Revision 33177)
> +++ files/lsm_script  (Arbeitskopie)
...
> +cat <<EOM | ssmtp ${WARN_EMAIL}

What if I don't have ssmtp on my router and/or I don't have a mail
server to point it at to send mail and/or I am not interested in being
nagged every time a link state changes?

> +Subject: "LSM: ${NAME} ${STATE}, DEV ${DEVICE}"
> +
> +Hi,
> +
> +Your connection ${NAME} has changed it's state to ${STATE} at ${DATE}.
...

> +Your LSM Daemon
> +
> +EOM
> +
...
> +
> +#EOF

Why is this commented-out "#EOF" needed here?

> Index: patches/110-MODULESDIR.patch
> ===================================================================
> --- patches/110-MODULESDIR.patch      (Revision 33177)
> +++ patches/110-MODULESDIR.patch      (Arbeitskopie)
> @@ -1,20 +0,0 @@
> ---- a/lib.common     2012-01-21 14:21:50.000000000 +0100
> -+++ b/lib.common     2012-06-03 11:52:35.115967105 +0200
> -@@ -328,7 +328,7 @@
> - 
> -     [ -z "$MODULESDIR" ] && \
> -     uname=$(uname -r) && \
> --    
> MODULESDIR=/lib/modules/$uname/kernel/net/ipv${g_family}/netfilter:/lib/modules/$uname/kernel/net/netfilter:/lib/modules/$uname/kernel/net/sched:/lib/modules/$uname/extra:/lib/modules/$uname/extra/ipset
> -+    
> MODULESDIR=/lib/modules/$uname/kernel/net/ipv${g_family}/netfilter:/lib/modules/$uname/kernel/net/netfilter:/lib/modules/$uname/kernel/net/sched:/lib/modules/$uname/extra:/lib/modules/$uname/extra/ipset:/lib/modules/$uname
> - 
> -     [ -d /sys/module/ ] || MODULES=$(lsmod | cut -d ' ' -f1)
> - 
> -@@ -367,7 +367,7 @@
> - 
> -     [ -z "$MODULESDIR" ] && \
> -     uname=$(uname -r) && \
> --    
> MODULESDIR=/lib/modules/$uname/kernel/net/ipv${g_family}/netfilter:/lib/modules/$uname/kernel/net/netfilter:/lib/modules/$uname/kernel/net/sched:/lib/modules/$uname/extra:/lib/modules/$uname/extra/ipset
> -+    
> MODULESDIR=/lib/modules/$uname/kernel/net/ipv${g_family}/netfilter:/lib/modules/$uname/kernel/net/netfilter:/lib/modules/$uname/kernel/net/sched:/lib/modules/$uname/extra:/lib/modules/$uname/extra/ipset:/lib/modules/$uname
> - 
> -     for directory in $(split $MODULESDIR); do
> -     [ -d $directory ] && moduledirectories="$moduledirectories $directory"

Why can this patch be removed?  i.e. does Shorewall now include
/lib/modules/$uname in it's MODULESDIR or has the kernel modules
location been updated to conform to one of the paths already in
MODULESDIR?  Or something else?

Cheers,
b.


Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to