Hi!

The patch is mangled by your MUA. I see some strange symbols. Also I
think that your indentation style is not quite readable.

В Wed, 18 Jul 2012 17:37:13 +0700
Сергей Василюгин <vasilu...@yandex.ru> пишет:

> Signed-off-by: Serge Vasilugin <vasilugin at yandex.ru>
> 
> Index: target/linux/ramips/files/arch/mips/ralink/rt305x/Kconfig
> ===================================================================
> --- target/linux/ramips/files/arch/mips/ralink/rt305x/Kconfig (revision 32760)
> +++ target/linux/ramips/files/arch/mips/ralink/rt305x/Kconfig (working copy)
> @@ -159,6 +159,11 @@
>          select RALINK_DEV_GPIO_BUTTONS
>          select RALINK_DEV_GPIO_LEDS
> 
> +config RT305X_MACH_DIR_620_REVA
> + bool "D-Link DIR-620 revA board support"
> + select RALINK_DEV_GPIO_BUTTONS
> + select RALINK_DEV_GPIO_LEDS
> +

IMO this should be spaced the same way as other boards. This helps
reading.

>  endmenu
> 
>  endif
> Index: target/linux/ramips/files/arch/mips/ralink/rt305x/mach-dir-620-reva.c
> ===================================================================
> --- target/linux/ramips/files/arch/mips/ralink/rt305x/mach-dir-620-reva.c 
> (revision 0)
> +++ target/linux/ramips/files/arch/mips/ralink/rt305x/mach-dir-620-reva.c 
> (revision 0)
> @@ -0,0 +1,104 @@
> +/*
> + *  D-Link DIR-620 rev A board support
> + *
> + *  Copyright (C) 2009-2010 Gabor Juhos <juh...@openwrt.org>
> + *  Copyright (C) 2012 Sergey Vasiliugin <vasilu...@yandex.ru>
> + *
> + *  This program is free software; you can redistribute it and/or modify it
> + *  under the terms of the GNU General Public License version 2 as published
> + *  by the Free Software Foundation.
> + */
> +
> +#include <linux/init.h>
> +#include <linux/platform_device.h>
> +
> +#include <asm/mach-ralink/machine.h>
> +#include <asm/mach-ralink/dev-gpio-buttons.h>
> +#include <asm/mach-ralink/dev-gpio-leds.h>
> +#include <asm/mach-ralink/rt305x.h>
> +#include <asm/mach-ralink/rt305x_regs.h>
> +
> +#include "devices.h"
> +
> +#define DIR_620A_GPIO_LED_STATUS_AMBER 8
> +#define DIR_620A_GPIO_LED_STATUS_GREEN 9
> +#define DIR_620A_GPIO_LED_WPS_BLUE 11
> +#define DIR_620A_GPIO_LED_WPS_GREEN 13

Hm, I think, this led (gpio 13) is amber in my dir-620. I'll check the
revision...

[snip]

-- 
  Alexander
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to