It looks like a similar change was made at r32073, adding "chmod 1777 $(1)/tmp" to package/base-files/Makefile. That has the effect of setting the sticky bit on /tmp in base-files.ipk, but the sticky bit is still clear in the root filesystem of generated images.
Either this patch is needed, or both the $(INSTALL_DIR) and chmod of /tmp need to be removed from include/image.mk. The latter approach relies on /tmp being provided by base-files (or any other package baked into the image) and having the correct mode, which as of r32073, it does. As it stands now, $(INSTALL_DIR) resets the mode to 0755, and the chmod that follows reset it to 0777, neither of which respect the desired 1777 mode now used in base-files.ipk. I wrote: > On the off chance that the root filesystem's /tmp is used directly as a > temporary directory instead of having a tmpfs mounted over it, it should have > the sticky bit set. > > Signed-off-by: Mark Mentovai <m...@moxienet.com> > > --- > > Index: include/image.mk > =================================================================== > --- include/image.mk (revision 31782) > +++ include/image.mk (working copy) > @@ -146,7 +146,7 @@ > - $(FIND) $(TARGET_DIR) -type f -perm +0100 -print0 | $(XARGS) -0 chmod > u+rwx,g+rx,o+rx > - $(FIND) $(TARGET_DIR) -type d -print0 | $(XARGS) -0 chmod > u+rwx,g+rx,o+rx > $(INSTALL_DIR) $(TARGET_DIR)/tmp > - chmod 0777 $(TARGET_DIR)/tmp > + chmod 1777 $(TARGET_DIR)/tmp > endef > > define Image/mkfs/prepare _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
