Also I'd like for there to be some way to not apply this patch on successor architectures such as the
- on ar724x, rx buffers can be aligned with an offset of 2, which keeps the ip header aligned - alignment offset is only added if the ar8216 workaround is not active and the phy driver does not advertise its own packet alignment On Tue, Apr 24, 2012 at 7:53 AM, Dave Taht <dave.t...@gmail.com> wrote: > On Tue, Apr 24, 2012 at 7:50 AM, David Woodhouse <dw...@infradead.org> wrote: >> On Tue, 2012-04-24 at 07:47 -0700, Dave Taht wrote: >>> b) However __packed leaks out of the main network header file, and was >>> not defined by iptables to be the define it is in the kernel code. >> >> How? When you run 'make headers_install' to export kernel headers for >> use by userspace, it *sanitizes* them, which includes automatically >> changing any instance of __packed to __attribute__((packed)). See >> scripts/headers_install.pl >> >> If someone is using headers that they've just copied out of the kernel, >> instead of using 'make headers_install', they deserve all the breakage >> they get. >> > > Hmm. OK. Well, it happened, so perhaps something in openwrt is doing > it wrong, or some pattern of mine while doing a build broke it. > > I'll try a clean build later this week, with the iptables patch > removed. Certainly it's cleaner to use __packed everywhere it is used. > > As for the former, I don't know enough of the innards of the openwrt > buildsystem to really even know where to look. > >> -- >> dwmw2 >> >> _______________________________________________ >> openwrt-devel mailing list >> openwrt-devel@lists.openwrt.org >> https://lists.openwrt.org/mailman/listinfo/openwrt-devel >> > > > > -- > Dave Täht > SKYPE: davetaht > US Tel: 1-239-829-5608 > http://www.bufferbloat.net -- Dave Täht SKYPE: davetaht US Tel: 1-239-829-5608 http://www.bufferbloat.net _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
