On 04/19/2012 11:43 AM, Emmanuel Deloget wrote:
> Force the use of known revision for specific eglibc versions.
> Eglibc revision can only be changed if the user selects the trunk
> version.
> 
> Signed-off-by: Emmanuel Deloget <log...@free.fr>
> 
> Index: toolchain/eglibc/Config.in
> ===================================================================
> --- toolchain/eglibc/Config.in    (révision 31345)
> +++ toolchain/eglibc/Config.in    (copie de travail)
> @@ -22,15 +22,19 @@
> 
>  endchoice
> 
> +config EGLIBC_TRUNK_REVISION
> +    string
> +    prompt "eglibc revision"
> +    depends on TOOLCHAINOPTS && USE_EGLIBC && EGLIBC_VERSION_TRUNK
> +    default "HEAD"
> +
>  config EGLIBC_REVISION
>      string
> -    prompt "eglibc revision"
>      depends on TOOLCHAINOPTS && USE_EGLIBC
>      default "14661" if EGLIBC_VERSION_2_12
>      default "15508" if EGLIBC_VERSION_2_13
>      default "16488" if EGLIBC_VERSION_2_14
> -    default "HEAD"  if EGLIBC_VERSION_TRUNK
> -    default ""
> +    default EGLIBC_TRUNK_REVISION if EGLIBC_VERSION_TRUNK
> 
>  menu "eglibc configuration"
>      depends on TOOLCHAINOPTS && USE_EGLIBC

The issue with "HEAD" is, that the fetched source will be packed and put
into dl/ (sth. like eglibc-trunk-HEAD.tar.gz).
In the next run this archive will be taken instead of fetching the "new"
HEAD, since it doesn't contain and rev-nr (but just 'HEAD') in the
revision-string and therewith in the filename.
There's also no checksum for the archive (obviously), so the build
system will not now when to re-fetch the src or to rely - which is the
default - on using the packed archive in dl/.

Since fetching the latest HEAD of any external source is uncommon and to
be avoided anyway (since builds are non-deterministic and changes to
external repositories might result in unpredictable build behaviours)
I'd like to drop the option of fetching trunk/HEAD at all. Comments?
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to