Maybe:

[ -n "$PROG" -a -x "$PROG" ] || return 1

instead?


On 3/22/12 4:34 PM, Etienne Champetier wrote:
> Hi
> 
> The 2 attached patchs (trunk & bacfire) add busybox ntpd enable_server 
> option, as busybox ntpd server is compiled by default.
> We only need 1 client/server daemon (olipro patch was launching 2 daemons)
> I've fully tested the bacfire patch, and as i don't have a running openwrt 
> trunk i'm not sure for the trunk patch (i'm sure about my modifications, but 
> i'm not sure about "[ -x $PROG ] || return 1", as "$PROG" isn't defined ?!)
> 
> Signed-off-by: Etienne CHAMPETIER <etienne.champet...@free.fr>
> 
> 
> Le 16/01/2012 01:57, Philip Prindeville a écrit :
>> On 1/14/12 11:37 AM, Olipro wrote:
>>> On Saturday 14 Jan 2012 02:45:59 Philip Prindeville wrote:
>>>> Don't we already have a 'disabled' option?  Now we're adding an
>>>> 'enable_server' option?
>>>>
>>>> That seems confusing for no useful reason.
>>>>
>>> have you bothered to read what I originally wrote? your response would make 
>>> me inclined to believe that you didn't.
>>>
>>> currently the ntpd initscript only runs it as a CLIENT - this patch enables 
>>> you to have one instance running as a client and another as a SERVER that 
>>> other hosts can synchronise with.
>>>
>>> Or perhaps I'm misunderstanding, what would you propose for allowing the 
>>> built-in busybox ntpd to be utilised as a server? a separate init script 
>>> entirely perhaps?
>> Or separate config sections... instead of 'config ntp' have 'config 
>> ntp-server' and 'config ntp-client'.
>>
>> -Philip
>>
>>
>> _______________________________________________
>> openwrt-devel mailing list
>> openwrt-devel@lists.openwrt.org
>> https://lists.openwrt.org/mailman/listinfo/openwrt-devel

_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to