Any reason to not use NElems() or ArraySize() or a similar macro, etc?
#define ArraySize(n) (sizeof(n) / sizeof(n[0]))
Seems it might help reduce churn.
On 2/22/12 6:56 AM, openwrt-comm...@openwrt.org wrote:
> Author: jow
> Date: 2012-02-22 14:56:06 +0100 (Wed, 22 Feb 2012)
> New Revision: 30685
>
> Modified:
> trunk/package/iwinfo/src/iwinfo_wl.c
> Log:
> [package] iwinfo: fix array size mismatch after r30684
>
>
> Modified: trunk/package/iwinfo/src/iwinfo_wl.c
> ===================================================================
> --- trunk/package/iwinfo/src/iwinfo_wl.c 2012-02-22 13:41:50 UTC (rev
> 30684)
> +++ trunk/package/iwinfo/src/iwinfo_wl.c 2012-02-22 13:56:06 UTC (rev
> 30685)
> @@ -489,18 +489,18 @@
> int wl_get_txpwrlist(const char *ifname, char *buf, int *len)
> {
> struct iwinfo_txpwrlist_entry entry;
> - uint8_t dbm[8] = { 0, 6, 8, 10, 12, 14, 16, 18, 20, 22, 24 };
> - uint8_t mw[8] = { 1, 3, 6, 10, 15, 25, 39, 63, 100, 158, 251 };
> + uint8_t dbm[11] = { 0, 6, 8, 10, 12, 14, 16, 18, 20, 22, 24 };
> + uint8_t mw[11] = { 1, 3, 6, 10, 15, 25, 39, 63, 100, 158, 251 };
> int i;
>
> - for (i = 0; i < 8; i++)
> + for (i = 0; i < 11; i++)
> {
> entry.dbm = dbm[i];
> entry.mw = mw[i];
> memcpy(&buf[i*sizeof(entry)], &entry, sizeof(entry));
> }
>
> - *len = 8 * sizeof(entry);
> + *len = 11 * sizeof(entry);
> return 0;
> }
>
>
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
