On 2011-12-18 3:16 PM, Mark Deneen wrote:
>>>> 3. While the LEDs function, they are registered after the ath9k.ko
>>>> module is loaded.  Because of this, the blinking preinit LED doesn't
>>>> show up, since the module is loaded after preinit starts.
>>> Shouldn't the red diag LED be the blinking preinit LED?
>>> According to your patch it's set up as a normal GPIO led.
>> Ah, I see. The code is using the green router LED. I think I'll change
>> it to use the diag LED instead.
>> By the way, your patch seems to set the wmac gpio to a bogus value. The
>> wireless LED at GPIO 5 should be configured as the wmac LED and not
>> registered as an extra LED. I'll take care of it.
> 
> I saw that the red diagnostic light was an option, since it was
> available at boot.  However, I was hoping to keep things as similar to
> the current G300NH, but maybe we should change the G300NH to match the
> NH2, since the diagnostic LED is likely to always be hooked up to to a
> normal GPIO.
> 
> As for the wmac gpio, I understand what it is doing now.  Sorry for
> the mistake there, I thought that it was doing something else.
Applied the patch with my modifications in r29567

- Felix
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to