> Date: Tue, 6 Dec 2011 23:08:36 -0500 > Subject: Re: [OpenWrt-Devel] [PATCH v2] Fix trx_fixup > From: m...@moxienet.com > To: openwrt-devel@lists.openwrt.org; nlhi...@hotmail.com > > I concur that there's something wrong with "mtd -j <jffs> write", as > used by sysupgrade when preserving configuration. The CRC in the TRX > header is computed before all writes that the CRC protects have > completed. I've worked around this problem in my brcm47xx builds by > running "mtd fixtrx" as part of the sysupgrade process. Your patch to > fix this properly in mtd looks correct to me. > The issue I was having has also been reported in https://dev.openwrt.org/ticket/10539. > On a related note, I haven't been able to understand why trx_fixup and > mtd_fixtrx don't share an implementation, and why the mtd_fixtrx > computes a CRC only over a single erase block. I noticed these as well, but was not comfortable providing a patch for a complete overhaul. At least for these, you don't end up with a router that doesn't boot. The truncated CRC is less than ideal. Nathan
_______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
