I just had a chance to flash a WNDR3800 with an image that contains this “machine name” patch (post-r29326). It's broken in two ways that I can see so far. These are regressions. The WNDR3800 images that used board=WNDR3700v2 worked properly in these cases. It remains my recommendation that this patch be backed out.
The bugs I've discovered are: 1. The power LED is broken. Once OpenWRT begins booting, the power LED turns off, and stays off. (target/linux/ar71xx/base-files/etc/diag.sh). 2. The network switch configuration is broken. Each port is in its own VLAN. There is no traffic passed between ports. (target/linux/ar71xx/base-files/etc/defconfig/wndr3800). I don't know how many other similar bugs there are, caused by other locations where you neglected to account for the new machine name and resultant ar71xx_board_name (target/linux/ar71xx/base-files/lib/ar71xx.sh). While it would be a simple matter to fix both of these, it would only reinforce the misconception that there are differences between these boards, when in fact there are none. I do believe it would be best to just back out this patch. Users who need a way to distinguish between WNDR3700v2 and WNDR3800 systems that are running are advised to read the art/caldata partition as previously mentioned. A WNDR3800 contains the string "WNDR3800" at the caldata/art partition at offset 56, length 10. Assuming caldata/art is on mtd5, you can obtain this by running |hexdump -v -e '/1 "%c"' -s 56 -n 10 /dev/mtd5|. A WNDR3700v2 or WNDR3700 just contains 0xff bytes at this location, so hexdump will give back ten question marks. _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
