On Fri, September 30, 2011 16:10, Emmanuel Deloget wrote: > Le 30/09/2011 14:59, Florian Fainelli a �crit : >> On Friday 30 September 2011 14:37:05 Eugene San wrote: >>> Ok. >>> I just tried to unify style of this file, and wasn't planning >>> tabs<->spaces >>> holy-war :-) >>> Although, both approaches can be found all over the code and there is >>> no >>> specific guidelines on subject. >> Agreed, in general I try to keep this style of 2 spaces for declarations >> inside define/endef blocks, but having tabs is also valid. Note sure >> about >> other editors, but vim for instance does a better highlighting job when >> using >> 2 spaces (it's Friday after all). > > Same for geany and gedit, as far as I can tell. With tabs, variable > definitions are not highlighted correctly (they are when 2 spaces are > used). > > -- Emmanuel Deloget
This is correct highlighting behaviour, as in Makefiles leading tabs and spaces have special and different meaning. Writing a Makefile is totally different to writing code. Maddes _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
