Hi,

On 25 September 2011 15:02, Alfred E. Heggestad <a...@db.org> wrote:
> Hi,
>
> a couple of weeks ago I released a new version of my open-source
> VOIP projects, which is now at version 0.3.0:
>
>  http://www.creytiv.com/
>
>
> this patch upgrades the following packages to v0.3.0:
>
>  baresip v0.3.0 (Portable and modular SIP User-Agent with audio and video
> support)
>  restund v0.3.0 (Modular STUN/TURN server)
>  libre   v0.3.0 (Generic library for real-time communications with async IO
> support)
>  librem  v0.3.0 (Audio and video processing media library)

Unless they depend on being the same version, these updates/adds
should be individual patches.
>
>
>
> I have also removed the @BROKEN symbol, as all packages build fine here with
> trunk r28297 for at least BRCM, AR7, x86 and UML architectures. I read on
> the forum
> that there was some problems building the programs but I did not find any
> reports
> on which architectures were failing or any build logs. would it be possible
> to
> get notified somehow if such a thing happens ?

If your programs needs NPTL/TLS, it might fail (to build) on some
platforms. I don't know whether this is the case. Look at the the
uclibc configuration for the targets; check if it has
LINUXTHREADS_OLD; you might want to try one of these targets.

> Please review and apply if OK. Thanks

Since these are yours, have you thought about applying for maintainership? ;-)

> Signed-Off-By: Alfred E. Heggestad

This isn't a valid SOB, you are missing your email address (don't
worry, trac and the ml-archives will filter it out for the publicly
visible parts).

Now on to the actual patch:
> ...
(snip)
> Index: feeds/packages/net/baresip/Makefile
> ===================================================================
> --- feeds/packages/net/baresip/Makefile       (revision 28297)
> +++ feeds/packages/net/baresip/Makefile       (working copy)
(snip)
> @@ -70,6 +70,7 @@
>               LIBRE_MK=../re-$(PKG_VERSION)/mk/re.mk \
>               LIBRE_INC=../re-$(PKG_VERSION)/include \
>               LIBRE_SO=$(STAGING_DIR)/usr/lib/libre.so \
> +             LIBREM_PATH=../rem-$(PKG_VERSION) \

These look wrong; is there a reason for not doing it like restund:

                LIBRE_MK=$(STAGING_DIR)/usr/share/re/re.mk \
                LIBRE_INC=$(STAGING_DIR)/usr/include/re \

> Index: feeds/packages/libs/rem/Makefile
> ===================================================================
> --- feeds/packages/libs/rem/Makefile  (revision 0)
> +++ feeds/packages/libs/rem/Makefile  (revision 0)
(snip)

> +define Build/Compile
> +     $(MAKE) -C $(PKG_BUILD_DIR) \
> +             LIBRE_INC=../re-$(PKG_VERSION)/include \

Same comment as above.


Regards
Jonas
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to