On 8/6/11 2:31 PM, Philip Prindeville wrote:
> On 8/6/11 10:09 AM, Hauke Mehrtens wrote:
>> On 07/28/2011 03:31 AM, Philip Prindeville wrote:
>>> Modules like input-gpio-keys rely on input-core, but that's not currently
>>> expressed.
>>>
>>> Signed-off-by: Philip Prindeville <phil...@redfish-solutions.com>
>>>
>> This patch is wrong.
>>
>> x86 has input-core compiled into the kernel and for all other targets
>> there is already a dependency on kmod-input-core in AddDepends/input.
>> This patch is not needed at all.
>>
>> Hauke
>
> It does?
>
>
> philipp@builder ~/openwrt2]$ grep CONFIG_INPUT target/linux/x86/config-default
> # CONFIG_INPUT is not set
> [philipp@builder ~/openwrt2]$ egrep '\<CONFIG_INPUT\>'
> build_dir/linux-x86_alix2/linux-2.6.39.3/.config
> # CONFIG_INPUT is not set
> [philipp@builder ~/openwrt2]$
And what's stranger than that...
define KernelPackage/input-gpio-buttons
SUBMENU:=$(OTHER_MENU)
TITLE:=Polled GPIO buttons input device
DEPENDS:=@GPIO_SUPPORT +kmod-input-polldev
KCONFIG:= \
CONFIG_INPUT_GPIO_BUTTONS \
CONFIG_INPUT_MISC=y
FILES:=$(LINUX_DIR)/drivers/input/misc/gpio_buttons.ko
AUTOLOAD:=$(call AutoLoad,62,gpio_buttons)
endef
so kmod-input-gpio-buttons pulls in kmod-input-polldev:
define KernelPackage/input-polldev
SUBMENU:=$(OTHER_MENU)
TITLE:=Polled Input device support
KCONFIG:=CONFIG_INPUT_POLLDEV
FILES:=$(LINUX_DIR)/drivers/input/input-polldev.ko
AUTOLOAD:=$(call AutoLoad,20,input-polldev)
$(call AddDepends/input)
endef
So when I do:
[philipp@builder ~/openwrt2]$ egrep 'CONFIG_INPUT'
build_dir/linux-x86_alix2/linux-2.6.39.3/.config
# CONFIG_INPUT is not set
[philipp@builder ~/openwrt2]$
Why am I not seeing CONFIG_INPUT_GPIO_BUTTONS, or CONFIG_INPUT_POLLDEV?
Oh, here it is in 001-depends.mk:
define SetDepends/input
DEPENDS:= @!TARGET_x86
endef
define AddDepends/input
DEPENDS+= +!TARGET_x86:kmod-input-core $(1)
endef
Yeah, that's not actually correct.
It should be:
define SetDepends/input
DEPENDS:=
endef
define AddDepends/input
DEPENDS+= +kmod-input-core $(1)
endef
Also, at the end of the file:
define SetDepends/rfkill
DEPENDS:=
@(TARGET_ar71xx||TARGET_brcm47xx||TARGET_s3c24xx||TARGET_x86||TARGET_gemini)
endef
define AddDepends/rfkill
DEPENDS+=
+(TARGET_ar71xx||TARGET_brcm47xx||TARGET_s3c24xx||TARGET_x86):kmod-rfkill $(1)
endef
I thought Jo-Philipp said that this syntax didn't actually work at this time?
What am I missing...
-Philip
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
