Jonas,
Thanks for the great pointers.
Re your comment below:
>This overwrites PKG_INSTALL:=1 - you either (can) use it, or you
>define your own install section. Please check which one is
>correct/working.
I understand that setting PKG_INSTALL:=1 will execute the "make
install" during the build which should work just fine. The problem I
have is when I remove completely or strip out all the the actions from
"define Package/pianobar/install", the package fails to build with the
error:
make[2]: Nothing to be done for `compile'.
Can you clarify what is expected syntax?
Thanks,
Adam
Message: 2
Date: Wed, 1 Jun 2011 16:40:30 +0200
From: Jonas Gorski <jonas.gorski+open...@gmail.com>
To: OpenWrt Development List <openwrt-devel@lists.openwrt.org>
Subject: Re: [OpenWrt-Devel] [PATCH] Add pianobar package
Message-ID: <BANLkTi=yupkk8ij0fufjhawbqytsgd0...@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Same comments for quoted printable and tabs as for your other email ;-)
On 30 May 2011 14:13, Adam Chasen <a...@chasen.name> wrote:
> This is one of my first patches for Openwrt. Please let me know if
> there are any improvements in style and submission.
Here you are ;-). This doesn't belong in the changelog of the patch
though, comments like this usually go under a tear off line:
<changelog>
---
<comments>
--- path/to/first/file...
>
> Signed-off-by: Adam Chasen <a...@chasen.name>
>
> Index: multimedia/pianobar/patches/001-Makefile-flags.patch
> ===================================================================
> --- multimedia/pianobar/patches/001-Makefile-flags.patch ? ? ? ?(revision 0)
> +++ multimedia/pianobar/patches/001-Makefile-flags.patch ? ? ? ?(revision 0)
Just missed this one in your libao patch: the patch should be
applyable with -p1, so the path should start with packages/ or a/
> @@ -0,0 +1,15 @@
> +--- a/Makefile
> ++++ b/Makefile
Just like this one :-)
> +@@ -6,9 +6,9 @@ LIBDIR:=${PREFIX}/lib
> + INCDIR:=${PREFIX}/include
> + MANDIR:=${PREFIX}/share/man
> + DYNLINK:=0
> +-CFLAGS:=-O2 -DNDEBUG
> +-LDFLAGS:=
> +-CC:=c99
> ++CFLAGS+=-O2 -DNDEBUG -std=c99
> ++LDFLAGS+=
> ++#CC:=c99
> +
> + PIANOBAR_DIR=src
> + PIANOBAR_SRC=\
> Index: multimedia/pianobar/Makefile
> ===================================================================
> --- multimedia/pianobar/Makefile ? ? ? ?(revision 0)
> +++ multimedia/pianobar/Makefile ? ? ? ?(revision 0)
> @@ -0,0 +1,45 @@
> +#
> +# Copyright (C) 2011 Adam Chasen (a...@chasen.name)
> +#
> +# This is free software, licensed under the GNU General Public License v3.
> +#
> +
> +include $(TOPDIR)/rules.mk
> +
> +PKG_NAME:=pianobar
> +PKG_VERSION:=2011.04.27
> +PKG_RELEASE:=1
> +
> +PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.bz2
> +PKG_SOURCE_URL:=http://6xq.net/static/projects/pianobar/
> +PKG_MD5SUM:=b92cba3cbcf1ee9bc221118a85d23dcd
> +
> +PKG_FIXUP:=libtool
> +PKG_INSTALL:=1
> +
> +include $(INCLUDE_DIR)/package.mk
> +
> +define Package/pianobar
> + ?SECTION:=multimedia
> + ?CATEGORY:=Multimedia
> + ?DEPENDS:=+libao +libmad +faad2
> + ?TITLE:=Pianobar: Pandora CLI
> + ?URL:=http://6xq.net/projects/pianobar/
> +endef
> +
> +define Package/pianobar/description
> + ? ? ? TODO
You should probably fix this.
> +endef
> +
> +define Build/Configure
> + ? ? ? $(call Build/Configure/Default, \
> + ? ? ? ? ? ? ? , \
> + ? ? ? )
> +endef
If you are calling Build/Configure/Default without any additional
parameters anyway, you can drop the define completely.
> +
> +define Package/pianobar/install
> + ? ? ? $(INSTALL_DIR) $(1)/usr/bin
> + ? ? ? $(INSTALL_BIN) $(PKG_INSTALL_DIR)/usr/local/bin/pianobar $(1)/usr/bin/
> +endef
This overwrites PKG_INSTALL:=1 - you either (can) use it, or you
define your own install section. Please check which one is
correct/working.
Jonas
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
