On 6/22/11 11:02 AM, Alexey I. Froloff wrote:
> On Wed, Jun 22, 2011 at 09:15:24AM -0700, Philip Prindeville wrote:
>> The warning only seems to be for line 369, so why change more than that?
> This is a modification of an older patch.  tag.reserved2 (now) is
> 16 bytes long, so it's OK.
> 
>> Also, what value does sizeof(tag.information1[0]) give?
> It doesn't matter.  Compiler knows that tag.information1 is
> TAGINFO1_LEN bytes long, which is less than ALTTAGINFO_LEN.  This
> is how _FORTIFY_SOURCE works in gcc...

Ok, so it sounds like the best fix would be:

strlcpy(&tag.information1[0], args->altinfo_arg, TAGINFO1_LEN);

Is that correct?
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to