OK, I reverted the commit.

However as stated in eglibc features ( http://www.eglibc.org/features ):

==
Building with -Os
EGLIBC supports building the library with compiler optimizing for size -Os instead of for speed -O2.
==

This is just wrong then.. *sigh*

Thanks

mirko


On Mon, 20 Jun 2011 09:01:36 +0300, Mika Laitio wrote:
On 06/20/2011 06:16 AM, Philip Prindeville wrote:
On 6/18/11 4:14 AM, openwrt-comm...@openwrt.org wrote:
Author: mirko
Date: 2011-06-18 13:14:01 +0200 (Sat, 18 Jun 2011)
New Revision: 27214

Modified:
    trunk/toolchain/eglibc/Makefile
Log:
[toolchain/eglibc} eglibc in fact can be built with -Os

Modified: trunk/toolchain/eglibc/Makefile
===================================================================
--- trunk/toolchain/eglibc/Makefile 2011-06-18 07:33:28 UTC (rev 27213) +++ trunk/toolchain/eglibc/Makefile 2011-06-18 11:14:01 UTC (rev 27214)
@@ -52,10 +52,6 @@
  HOST_BUILD_DIR1:=$(HOST_BUILD_DIR)-initial
  HOST_BUILD_DIR2:=$(HOST_BUILD_DIR)-final

-# XXX: {e,}glibc does not build w/ -Os
-# http://sourceware.org/bugzilla/show_bug.cgi?id=5203
-EGLIBC_CFLAGS:=$(subst -Os,-O2,$(TARGET_CFLAGS))
-
  EGLIBC_CONFIGURE:= \
        BUILD_CC="$(HOSTCC)" \
        $(TARGET_CONFIGURE_OPTS) \



I'm seeing a regression:

I got same build failure for
toolchain-mips_r2_gcc-linaro_eglibc-2.12/eglibc-2.12-r10495-initial
target.


/home/lamikr/misc/src/openwrt/openwrt_trunk.git/build_dir/toolchain-mips_r2_gcc-linaro_eglibc-2.12/eglibc-2.12-r10495-initial/config.h:3:3:
error: #error "glibc cannot be compiled without optimization"
make[6]: ***

[/home/lamikr/misc/src/openwrt/openwrt_trunk.git/build_dir/toolchain-mips_r2_gcc-linaro_eglibc-2.12/eglibc-2.12-r10495-initial/tcb-offsets.h]
Error 1


Mika
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to