On 4 June 2011 15:39, Florian Fainelli <flor...@openwrt.org> wrote: > Hello Jonas, > > On Saturday 14 May 2011 16:54:56 Jonas Gorski wrote: >> Since 2.6.38 the bridge module has a dependency to IPv6 if IPv6 is >> enabled. Since the IPv6 module isn't exactly lightweight and bridge also >> only needs a single function from IPv6, it's rather easy to create a >> common "lib" module with a RCU pointer to the actual implementation, if >> the IPv6 module is loaded (although slightly hackish). >> >> The codepath seems to be only taken when using IPv6, so there should be >> no negative side effects when IPv6 isn't loaded. I did not measure how >> big the performance impact is. >> >> Signed-off-by: Jonas Gorski <jonas.gorski+open...@gmail.com> > > The patch looks good at first sight, can you post it on netdev to gather some > opinions from the Linux networking stack developpers?
I can try. My top most reason why I didn't do it yet is that the code is currently quite hackish (it's more like trying to treat the symptom than the cause) and I didn't find a clean solution yet (not really knowing the whole net subsystem doesn't help there either ;-). Also I still didn't check for any negative performance impacts yet (there is definitely one, but I don't know if the code paths are called seldom enough for it to be neglectible). Jonas _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
