On 16 May 2011 20:00, Philip Prindeville <philipp_s...@redfish-solutions.com> wrote: > On 5/16/11 2:34 AM, Felix Fietkau wrote: >> On 2011-05-16 6:45 AM, Philip Prindeville wrote: >>> Fixes for the following warnings: >>> >>> drivers/mtd/devices/block2mtd.c: In function '_open_bdev': >>> drivers/mtd/devices/block2mtd.c:272:3: warning: ISO C90 forbids mixed >>> declarations and code >>> drivers/mtd/devices/block2mtd.c: In function 'add_device': >>> drivers/mtd/devices/block2mtd.c:399:13: warning: assignment discards >>> qualifiers from pointer target type >>> >>> Can someone get these upstream. >>> >>> Signed-off-by: Philip Prindeville<phil...@redfish-solutions.com> >> If I remember correctly, this is not an upstream issue, but a problem in >> one of the patches. Please fold your fix into that patch (for 2.6.38 as >> well if it has the issue as well), then resubmit. >> >> - Felix > > Here it is as patched patches for 2.6.37.6.
> Index: > target/linux/generic/patches-2.6.37/410-mtd_info_move_forward_decl.patch > =================================================================== > --- target/linux/generic/patches-2.6.37/410-mtd_info_move_forward_decl.patch > (revision 26907) > +++ target/linux/generic/patches-2.6.37/410-mtd_info_move_forward_decl.patch > (working copy) > (...) > +- strcpy(dpart->name, ROOTFS_SPLIT_NAME); > ++ strcpy((char *)&dpart[1], ROOTFS_SPLIT_NAME); This line gets added in 400-rootfs_split.patch, so IMHO it would make more sense to change it there. 2.6.38 and 2.6.39 need it, too (also every older kernel, but I think these are okay to ignore; the appropriate targets should rather be updated to newer kernels ;). > Index: target/linux/generic/patches-2.6.37/442-block2mtd_probe.patch > =================================================================== > --- target/linux/generic/patches-2.6.37/442-block2mtd_probe.patch > (revision 26907) > +++ target/linux/generic/patches-2.6.37/442-block2mtd_probe.patch > (working copy) > (...) > - dev_t devt = name_to_dev_t(dev->devname); > +- dev_t devt = name_to_dev_t(dev->devname); > ++ devt = name_to_dev_t(dev->devname); This line is actually from 441-block2mtd_refresh.patch, so it should be changed there (like it is already for 2.6.38 and 2.6.39). Jonas _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
