On 4/13/11 3:10 PM, Larry Vaden wrote: > On Wed, Apr 13, 2011 at 2:59 PM, Felix Fietkau <n...@openwrt.org> wrote: >> On 2011-04-12 2:18 PM, Jan Čapek wrote: >>> >>> - this configuration option seems to be undocumented. Unfortunately, >>> it tries to disable powersaving by default for all mac80211 based >>> wifi interfaces that use 'sta' mode. Some drivers (e.g. ath5k) don't >>> support setting/enabling powersaving mode. The result is an error >>> message when bringing wifi up. This change makes the setting >>> optional. >> >> I think on devices that support powersave, it still needs to be turned off >> by default. powersave is a big source of performance/reliability issues. >> Please rework this patch to either explicitly check for powersave support or >> to hide the error message. > > While I realize the breach of netiquette involved in a non-developer > commenting, I would like to second Felix's motion. > > There's enough that can go wrong on the "invisible wire" without using > a pair of wire cutters on it from time to time :) >
There's such an etiquette? If there is, it would seem to be misguided. There are always going to be more users than developers (if it was easy, everyone would be doing it, right?). Users are well placed to say what they need and how they expect things to operate: these are "requirements". I as a developer don't want to be cranking out code in a vacuum with no understanding of user expectations. Please be as uncouth, impudent, and impertinent as possible. :-) -Philip _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
