On Wed, 2011-03-30 at 17:07 +0200, Felix Fietkau wrote:
> On 2011-03-30 4:06 PM, Maarten Bezemer wrote:
> > I am having the same error with 2.6.37.4 (for orion target).
> > The Makefile in the crypto dir seems to be broken...
> >
> > It contains something like (from top of my head so don't shoot me if I
> > am wrong):
> >    hash_objs += ahash.o
> >    hash_objs += shash.o
> >
> > But the hash_objs variable is never used...
> > A simple fix is to changes 'hash_objs' to 'objs', but then those 2 files
> > are always included. This did not seem a good solution to me, so I did
> > not send a patch yet...
> > As I did not have time to look further into this problem and I supposed
> > the kernel developers need to fix this, I was waiting for a solution.
> Should be fixed in r26372
> 
> - Felix

I was wrong, I have another problem:

  LD      vmlinux
drivers/built-in.o: In function `mv_remove':
staging.c:(.text+0x49250): undefined reference to `crypto_unregister_ahash'
staging.c:(.text+0x49264): undefined reference to `crypto_unregister_ahash'
drivers/built-in.o: In function `mv_probe':
staging.c:(.text+0x494f0): undefined reference to `crypto_register_ahash'
staging.c:(.text+0x49518): undefined reference to `crypto_register_ahash'
drivers/built-in.o: In function `mv_hash_final_fallback':
staging.c:(.text+0x49b58): undefined reference to `crypto_shash_update'
staging.c:(.text+0x49be8): undefined reference to `crypto_shash_final'
drivers/built-in.o: In function `queue_manag':
staging.c:(.text+0x4a0e8): undefined reference to `crypto_ahash_type'
drivers/built-in.o: In function `mv_cra_hash_init':
staging.c:(.text+0x4a21c): undefined reference to `crypto_alloc_shash'
staging.c:(.text+0x4a258): undefined reference to `crypto_alloc_shash'
drivers/built-in.o: In function `mv_hash_setkey':
staging.c:(.text+0x4a358): undefined reference to `crypto_shash_setkey'
staging.c:(.text+0x4a3e0): undefined reference to `crypto_shash_digest'
staging.c:(.text+0x4a478): undefined reference to `crypto_shash_update'
staging.c:(.text+0x4a4cc): undefined reference to `crypto_shash_update'

Which is fixed by updating this part of the crypto/Makefile
  crypto_hash-objs += ahash.o
  crypto_hash-objs += shash.o

by replacing 'crypto_hash-objs' to 'objs'. Which has the (undesired?)
side-effect that ahash.c and shash.c are always included in the
kernel...

In the same Makefile, I also notice the crypto-objs, crypto_algapi and
cryptomgr-objs variables. I suppose these have the same problem?

This problem occurs is in kernel versions 2.6.37.4 and 2.6.37.6 (I did
not look at other versions).

Greetings,
  Maarten

_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to