Hi Laurento,
Ah, I was too slow, it's already commited; I do have some comments.
Perhaps you could do a follow up patch, assuming you agree with my comments.
On 15 February 2011 18:28, Laurento Frittella
<laurento.fritte...@gmail.com> wrote:
> Thanks to KanjiMonster for the support on the IRC channel.
You're welcome :)
> Index: target/linux/brcm63xx/patches-2.6.35/450-board-MAGIC.patch
> ===================================================================
> --- target/linux/brcm63xx/patches-2.6.35/450-board-MAGIC.patch (revisione 0)
> +++ target/linux/brcm63xx/patches-2.6.35/450-board-MAGIC.patch (revisione 0)
> @@ -0,0 +1,89 @@
> +Index: linux-2.6.35.9/arch/mips/bcm63xx/boards/board_bcm963xx.c
> +===================================================================
> +--- linux-2.6.35.9.orig/arch/mips/bcm63xx/boards/board_bcm963xx.c
> ++++ linux-2.6.35.9/arch/mips/bcm63xx/boards/board_bcm963xx.c
> +@@ -775,6 +775,76 @@ static struct board_info __initdata boar
> + },
> + };
> +
> ++static struct board_info __initdata board_96348sv = {
You might want to give this struct a different name, since it isn't a
96348sv. Perhaps "board_telsay_magic" or "board_alice_wgate" would be
clearer. Someday somebody might want to add the definition for the
actual 96348sv, and then has a name conflict with your definition.
You might also want to add a line to target/brcm63xx/image/Makefile so
Images with the device's name get created, so that others know which
image to use.
Regards,
Jonas
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
