On Thu, Feb 10, 2011 at 08:17:53PM -0800, Philip Prindeville wrote: > Not sure what that means to say "all linux router by default honours the TOS > field" since that depends on how/if you have 'tc' configured, and which > scheduler you're using. On every box that I have that requires QoS, I've > used the hfsc scheduler... though a lot of my infrastructure is also Cisco > stuff.
It seems you are not getting it but it's very simple: Linux by using the default pfifo_fast queue discipline always honours QoS values in the TOS field even if you don't have "tc configured". What this means is that OpenWRT and all those Linux home routers honours the TOS field out of the box when routing packets, your patch contradicts this fact and now OpenSSH will do weird things on a OpenWRT router by setting DiffServ values in the TOS field which will trigger unknown or incorrect behavior. In the best case users will not notice/care. Hopefully your patch receives more discussion on upstream OpenSSH. > <snip> As your patch was merged yesterday it's end of discussion for me. _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
