Hi,

yes, but why does this need a init hook int he pci code ? this should be
put inside the mach-*.c file imo

John


On 24/11/10 12:51, ngp ngp wrote:
> ath5k gets eeprom data from eeprom in card or from platform data of device,
> so if theres no eeprom, this data should be in platform data. Theres a need
> to set this platform data for pci device from platform setup code.
> 
> It is similar to whats done in ar71xx.
> 
> 
> 
> 2010/11/24 John Crispin <j...@phrozen.org>
> 
>> Hi,
>>
>> i dont understand why this needs to be in the pci driver
>>
>> on madwifi we fixed this by patching the driver. the generic pcoi code
>> should be fully agnostic of the ath5k eep residing in flash.
>>
>> John
>>
>> On 24/11/10 11:35, ngp ngp wrote:
>>> Set platform data to flash stored eeprom for ath5k
>>>
>>> static struct ath5k_platform_data arv4518_ath5k_platform_data;
>>> static int arv4518_pci_plat_dev_init(struct pci_dev *dev)
>>> {
>>>         if ((dev->vendor == PCI_VENDOR_ID_ATHEROS) && (dev->device ==
>>> 0xff1b))
>>>                   dev->dev.platform_data = &arv4518_ath5k_platform_data;
>>>
>>>         return 0;
>>> }
>>>
>>> Or any other per pci device  platform initialization required.
>>>
>>>
>>> 2010/11/24 John Crispin <j...@phrozen.org>
>>>
>>>> Hi,
>>>>
>>>> what is the purpose of the hook ?
>>>>
>>>> Thanks,
>>>> John
>>>>
>>>> On 24/11/10 01:45, ngp ngp wrote:
>>>>> Add hook for platform pci device init. It will permit use of eeprom
>> data
>>>>> stored in flash of wireless (ath5k)  pci card as platform data.
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> openwrt-devel mailing list
>>>>> openwrt-devel@lists.openwrt.org
>>>>> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
>>>>
>>>> _______________________________________________
>>>> openwrt-devel mailing list
>>>> openwrt-devel@lists.openwrt.org
>>>> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
>>>>
>>>
>>>
>>>
>>> _______________________________________________
>>> openwrt-devel mailing list
>>> openwrt-devel@lists.openwrt.org
>>> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
>>
>> _______________________________________________
>> openwrt-devel mailing list
>> openwrt-devel@lists.openwrt.org
>> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
>>
> 
> 
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel

_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to