nbd and friends: I discovered another bug in the ath9k WNDR3700 quirk fix from r23822. ath9k_hw_apply_gpio_override was testing the original value of gpio_mask to determine which bits were appropriate, instead of testing the shifted value. Because bit 0 is always clear in the original value, this resulted in no calls to set the GPIOs, an improperly-configured radio, and reduced RSSI on other systems listening to the radio.
Signed-off-by: Mark Mentovai <m...@moxienet.com> --- Index: package/mac80211/patches/310-ath9k_gpio_settings.patch =================================================================== --- package/mac80211/patches/310-ath9k_gpio_settings.patch (revision 23883) +++ package/mac80211/patches/310-ath9k_gpio_settings.patch (working copy) @@ -36,7 +36,7 @@ + int i; + + for (i = 0; gpio_mask; i++, gpio_mask >>= 1) { -+ if (!(ah->gpio_mask & 1)) ++ if (!(gpio_mask & 1)) + continue; + + ath9k_hw_cfg_output(ah, i, AR_GPIO_OUTPUT_MUX_AS_OUTPUT); _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel