Hi Florian,

I move the register enums to dev-spi.c because it's arch dependent, this place seems more appropriate and it match the irq, membase handling functions.

Kind regards,
Tanguy Bouzéloc.

On 11/10/2010 10:28, Florian Fainelli wrote:
Hello Tanguy,

On Friday 08 October 2010 18:15:50 Tanguy Bouzéloc wrote:
   Hi Florian,

I've updated the patches for 2.6.35 as you requested.

I'm testing the spi bus with a si3216 slic and a si3050 daa. The patch
do not contain cs and preprend fixes yet (testing ATM).
The patch looks good, and I will apply it. I am just curious, why did you move
the register enum to dev-spi.c and not in bcm63xx_spi.c like it used to be? (I
ask because this just makes the number of changes bigger).

Kind regards,
Tanguy Bouzéloc.

On 04/10/2010 23:43, Florian Fainelli wrote:
Hi Tanguy,

Le Friday 1 October 2010 15:33:44, Tanguy Bouzéloc a écrit :
    Hello,

I've started to rework bcm63xx spi patches and make them work for a
similar board, I've yet to confirm they are ok for neufbox4.

Some issues are remaining (chip select, prepend bytes ...), please feel
free to give me your opinion about them.

I hope next week I can correct theses issues.
Can you work on the 2.6.35 patches instead? I would like to remove 2.6.32
support soon, so that we focus on recent kernels. Otherwise, your patches
look good at a first glance.

What kind of SPI slave are you testing this with? SLIC/SLAC or ethernet
switches and/or flashes?

Thank you very much for your work.
--
Florian


_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to