So, if there are no problems, how about commiting it? Roman
On 20 September 2010 23:57, Philip Prindeville <philipp_s...@redfish-solutions.com> wrote: > No other issues here (but then, I'm not an official reviewer). > > > On 9/20/10 1:25 PM, Roman Yeryomin wrote: >> >> Sure, good idea! >> >> Roman >> >> On 20 September 2010 04:20, Philip Prindeville >> <philipp_s...@redfish-solutions.com> wrote: >>> >>> There are a lot of magic numbers in this code, like 64 and 16383 >>> appearing >>> in several places. >>> >>> Can they be done as #define manifest constants instead? >>> >>> Or better yet, perhaps as const uint's so they're visible in a >>> source-level >>> debugger. >>> >>> Thanks, >>> >>> -Philip >>> >>> >>> >>> On 9/19/10 5:35 PM, Roman Yeryomin wrote: >>>> >>>> Hi! >>>> Ok.. first sorry for the delay, second thanks for comments! >>>> Let's split this. Here is a patch for port rate, port and qos >>>> enable/disable support. >>>> >>>> Roman >>>> >>>> On 2 September 2010 10:47, Gabor Juhos<juh...@openwrt.org> wrote: >>>>> >>>>> 2010.08.26. 1:17 keltezéssel, Roman Yeryomin írta: >>>>>> >>>>>> Using this patch it's possible to define port egress/ingress bandwidth >>>>>> limit with 64 kbps step (this also requires enable_qos set to 1 which >>>>>> seems to be 1 already by default after switch reset), enable or >>>>>> disable any port and set vlan to different fid (0-7). Implementation >>>>>> of fid support maybe a bit ugly and could be done together with >>>>>> set_vlan_ports (which sets fid to 0 by default so after every `set >>>>>> ports ...` one need to `set fid ...` also) but this way it works fine >>>>>> too. >>>>>> >>>>>> Signed-off-by: Roman Yeryomin<ro...@advem.lv> >>>>>> -- >>>>>> >>>>>> Index: target/linux/generic/files/drivers/net/phy/rtl8366rb.c >>>>>> =================================================================== >>>>>> --- a/target/linux/generic/files/drivers/net/phy/rtl8366rb.c >>>>>> (revision >>>>>> 22745) >>>>>> +++ b/target/linux/generic/files/drivers/net/phy/rtl8366rb.c (working >>>>>> copy) >>>>> >>>>> You don't have to duplicate the VLAN access code, you can use the >>>>> get_vlan_4k() >>>>> function of smi->ops instead. Additionally, if you would use that, then >>>>> this >>>>> function would be generic, and should go into rtl8366_smi.c. >>> > > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/mailman/listinfo/openwrt-devel > _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
