--- Begin Message ---
Florian,

Thanks for your response.  I'm not sure whether this is
the correct place to discuss this topic or whether it
should be on the forum, so please let me know if I need
put it there instead.  Comments below...

Florian Fainelli wrote:
Hi Kerry,

Le Tuesday 22 June 2010 02:32:45, Kerry Lynn a écrit :
<snip>

I have a few concerns.  First, if these Asus models are underclocked but
there are other routers out there that aren't, then these mods should be
applied by platform+model and I don't know how to do that.

Exactly, that's why the patch should be more specific and check for a blacklist of models or ideally, a specific chipco version for instance. For instance, the WL-520-GC does not seem to have that issue, though it's a WL-520 GU without USB basically (at least CFE says the CPU freq is 240Mhz).

This is a great clue and one I will follow up on.  Have you run the
"date" test yourself on this model or know for certain that it works?
If it does work then I would ask whether the WL520-GC has a 25MHz or
30MHz crystal?  Perhaps Asus have only underclocked 5354+USB models.
Is there an archived copy of cfe-1.0.37-src somewhere?  The BCM site
only shows cfe-1.40.  I'll look into it tonight.


My routers report 240MHz from CFE and yet the patch corrects their
timekeepers.  An interesting factoid is that w/o the patch, bogomips
is reported as ~240MHz at boot and ~200MHz with the patch.  I'd also
be curious to know if the 520-GU and 520-GC have the same CFE version.

Finally, I note that NVRAM on my WL520-GU contains:
clkfreq=240 and
xtalfreq=25000

so this seems to suggest that Asus expect 240MHz operation with
a 25MHz crystal.

Regards, -K-

Second, I know some changes were made to the usb system to improve its
reliability but I wonder if there may be an interaction between my
changes and the usb changes?  I.e. did they compensate for a 16.66%
error in jiffies that is now corrected by my patch?

No idea about that.

Lastly, there's a patch file in 2.6 (220-bcm5354.patch) that applies the
incorrect timer values.  If my changes are accepted, they should really
go into this file.  Is it OK to submit a patch to a .patch file?

Yes this is ok, and this is actually how we would integrate it.
--
Florian



--- End Message ---
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to