No, it might have been missed, because this code piece had already been
removed from the pppoe.sh script. Both pptp.sh and pppoe.sh scripts called
the ppp.sh scripts.

Regards,
Murat


>
> Message: 5
> Date: Sat, 3 Apr 2010 00:26:58 +0300
> From: Bayram Kurumahmut <bayram.kurumah...@gmail.com>
> To: OpenWrt Development List <openwrt-devel@lists.openwrt.org>
> Subject: Re: [OpenWrt-Devel] patch for pptp package
> Message-ID:
>        <w2g5165ab001004021426hb9771334h7d2d03dcd40c3...@mail.gmail.com>
> Content-Type: text/plain; charset="iso-8859-1"
>
> I am sorry for Turkish reply :)
>
> Here is the English version:
>
> As a guess, ppp.sh may be the generic setting location and applications
may
> override these type of settings.
>
> Regards,
> Bayram
>
> On 3 April 2010 00:25, Bayram Kurumahmut <bayram.kurumah...@gmail.com
>wrote:
>
>> Selam Murat,
>>
>> Nasilsin?
>>
>> ppp.sh generic bir dosya olarak kabul edilip, application specific olan
>> script lerde bu gibi variable lar overwrite ediliyor olabilir.
>>
>> Yani bu tarz bisey dusunerek yapmis olabilirler.
>>
>> Hadi kolay gelsin,
>> Bayram
>>
>>
>> On 2 April 2010 22:02, Murat Sezgin <sezginmu...@gmail.com> wrote:
>>
>>> Hi,
>>>
>>> I am proposing the below patch for pptp package. Because this ifname
>>> correction is done in the ppp.sh script for all the ppp based
>>> protocols.
>>>
>>> Thanks,
>>> Murat Sezgin
>>> www.ubicom.com
>>>
>>>
>>> diff --git a/package/pptp/files/pptp.sh b/package/pptp/files/pptp.sh
>>> index e38c242..6008a48 100644
>>> --- a/package/pptp/files/pptp.sh
>>> +++ b/package/pptp/files/pptp.sh
>>> @@ -31,11 +31,6 @@ setup_interface_pptp() {
>>>        config_get netmask "$config" netmask
>>>        [ -z "$netmask" -o -z "$device" ] || ifconfig $device netmask
>>> $netmask
>>>
>>> -       # make sure the network state references the correct ifname
>>> -       scan_ppp "$config"
>>> -       config_get ifname "$config" ifname
>>> -       uci_set_state network "$config" ifname "$ifname"
>>> -
>>>        config_get mtu "$config" mtu
>>>        mtu=${mtu:-1452}
>>>        start_pppd "$config" \
>>> _______________________________________________
>>> openwrt-devel mailing list
>>> openwrt-devel@lists.openwrt.org
>>> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
>>>
>>
>>
>>
>> --
>> Bayram
>>
>
>
>
> --
> Bayram
> -------------- next part --------------
> An HTML attachment was scrubbed...
> URL: <
http://lists.openwrt.org/pipermail/openwrt-devel/attachments/20100403/c7a21683/attachment.html
>
>
> ------------------------------
>
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
>
>
> End of openwrt-devel Digest, Vol 52, Issue 3
> ********************************************
>



-- 
Murat Sezgin
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to