Hi Gianfranco,

Le vendredi 12 mars 2010 23:18:32, Gianfranco Bauco a écrit :
> This patch add support Alice Gate W2+ (also referred as AliceV3_S1 or
>  "Vela"), Broadcom bcm63xx-based routers, distributed in Italy by Telecom.
>  Unfortunately the fylesystem inizialization occurring during the first
>  boot make subsequent boot-ups fail because of a bad CRC of the flash image
>  (problem known already
>  https://lists.openwrt.org/pipermail/openwrt-devel/2009-August/004815.html
>  ). Of course DSL is NOT working.
> 
> Signed-off-by: Gianfranco Bauco
> 
> Index: target/linux/brcm63xx/patches-2.6.32/099-cfi_probe_error.patch
> ===================================================================
> ---
>  target/linux/brcm63xx/patches-2.6.32/099-cfi_probe_error.patch       
> (revision
>  0) +++
>  target/linux/brcm63xx/patches-2.6.32/099-cfi_probe_error.patch       
> (revision
>  0) @@ -0,0 +1,14 @@
> +--- a/drivers/mtd/chips/gen_probe.c
> ++++ b/drivers/mtd/chips/gen_probe.c
> +@@ -127,9 +127,9 @@
> +      * chip in read mode.
> +      */
> +
> +-    for (i = 1; i < max_chips; i++) {
> ++    /*for (i = 1; i < max_chips; i++) {
> +             cp->probe_chip(map, i << cfi.chipshift, chip_map, &cfi);
> +-    }
> ++    }*/
> +

Why is this patch required? Cannot you find a better way not to break other 
Flash chips?

> +     /*
> +      * Now allocate the space for the structures we need to return to
> Index: target/linux/brcm63xx/patches-2.6.32/131-board_AG3.patch
> ===================================================================
> --- target/linux/brcm63xx/patches-2.6.32/131-board_AG3.patch  (revision 0)
> +++ target/linux/brcm63xx/patches-2.6.32/131-board_AG3.patch  (revision 0)
> @@ -0,0 +1,40 @@
> +Index: linux-2.6.32.9/arch/mips/bcm63xx/boards/board_bcm963xx.c
> +===================================================================
> +--- linux-2.6.32.9/arch/mips/bcm63xx/boards/board_bcm963xx.c (revision
>  20072) ++++
>  linux-2.6.32.9/arch/mips/bcm63xx/boards/board_bcm963xx.c     (working copy)
>  +Index:
>  target/linux/brcm63xx/files-2.6.30/arch/mips/bcm63xx/boards/board_bcm963xx
> .c +@@ -470,6 +470,26 @@
> +             .force_duplex_full      = 1,
> +     },
> + };
> ++
> ++static struct board_info __initdata board_alicev3_s1 = {
> ++    .name                           = "Alice Gate W2+",
> ++    .expected_cpu_id                = 0x6348,
> ++
> ++    .has_enet0                      = 1,
> ++    .has_enet1                      = 1,
> ++    .has_pci                        = 1,
> ++
> ++    .enet0 = {
> ++            .has_phy                = 1,
> ++            .use_internal_phy       = 1,
> ++    },
> ++    .enet1 = {
> ++            .force_speed_100        = 1,
> ++            .force_duplex_full      = 1,
> ++    },
> ++
> ++    .has_ohci0 = 1,
> ++};
> + #endif
> +
> + /*
> +@@ -696,6 +716,7 @@
> +     &board_DV201AMR,
> +     &board_96348gw_a,
> +     &board_rta1025w_16,
> ++    &board_alicev3_s1,
> + #endif
> +
> + #ifdef CONFIG_BCM63XX_CPU_6358
> 
> 

This part looks good.

Please rework the CFI part of the patch, as I think it has side effects for 
other brcm63xx routers and resend the patch as a text, not HTML.

Thank you
--
Florian

Attachment: signature.asc
Description: This is a digitally signed message part.

_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to