Well, using DEVICE_TYPE does not solve the issue, it will just prevent
netfilter modules from being embedded in the final images, but wont
prevent them from being built and that will just fail for those targets
that have CONFIG_NETFILTER not set.

There are 2 options now if we don't want a FIREWALL "feature" :

1) set CONFIG_NETFILTER=y in all targets, even for those that don't
need/use it ;

2) move CONFIG_NETFILTER=y out of kernel configs and add it to KCONFIG
in kmod-ipt-core, which will have almost the same effect as (1) but
Netfilter will only be enabled in target kernels if kmod-ipt-core is
selected.

The current way of solving those issues right now have been a bunch of 
DEPENDS:=@(!(TARGET_ps3||TARGET_pxcab)||BROKEN) where appropriate. We
need to find a Better Way To Do It (tm) here (the same apply to
CONFIG_WIRELESS btw).

Feedback welcome (and mandatory) ;)

Regards,
--
-{Nico}


Imre Kaloz wrote:
> On 2010.03.01. 12:34:03 Nico <n...@openwrt.org> wrote:
>
>> Just to be clear, it's not intended to be a selectable feature, it will
>> just be defined if CONFIG_NETFILTER is defined in the target kernel
>> config, like it is for the GPIO, PCI or USB "features".
>>
>> What do you mean by "migrate to the DEVICE_TYPE" ?
>
> Check include/target.mk and how etrax/xburst/ps3 uses it.
>
>
> Imre

_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to