On 28-02-10 11:58, Matthias Buecher / Germany wrote:
> Just my two cents:
> Maybe some OpenWrt team members can review if the option rename causes
> hassle to the normal end user.
Isn't that the point of sending patches to this list? ;-) IMO, since
this patch is for trunk, it shouldn't be too much of a problem, as long
as it's documented. New installs will automatically have the correct
option in the config, and if no ports are specified on the command line
dropbear seems to listen on port 22 anyway.
> Multiple ports will be rarely used by normal users (same as with multiple
> instances), and advanced users should find out fast that they can list
> several ports separated by space in the port option.
I previously just hardcoded the extra port in the init script, but
created this patch after I heard someone in #OpenWrt did exactly the
same ;-)
> On the other side the plural "ports" fits much better the new
> functionality.
Exactly my thought, but let's leave it up to team to decide.
>
> As I said just my two cents
> Maddes
>
> On 28.02.2010 11:30, Stijn Tintel wrote:
> > On 28-02-10 11:28, Stijn Tintel wrote:
> >> This patch allows multiple listen ports to be configured for
> dropbear in
> >> /etc/config/dropbear. It renames the 'Port' option to 'Ports', so this
> >> will break existing configs.
> >>
> >> Regards,
> >> Stijn
> >>
> > 2nd attempt with attach :-)
>
>
Regards,
Stijn
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
