On Tue, 11 Aug 2009 00:47:33 -0400 Daniel Dickinson <crazycsh...@gmail.com> wrote:
> On Tue, 11 Aug 2009 03:18:58 +0200 > Felix Fietkau <n...@openwrt.org> wrote: > > > The patch looks wrong to me. sizeof on a constant string should > > return its length + 1 (for the null byte). In your patch however > > you use a > > I'm pretty sure that's not true. sizeof is the sizeof a type, in this > case char. I remember that because I've made that error before. My > second patch on the ticket works, where as the code present in the > trunk doesn't. Ok, you're right. I'll have to check what other changes I did, since it now works (with my patch), but the code that was there doesn't. -- And that's my crabbing done for the day. Got it out of the way early, now I have the rest of the afternoon to sniff fragrant tea-roses or strangle cute bunnies or something. -- Michael Devore GnuPG Key Fingerprint 86 F5 81 A5 D4 2E 1F 1C http://gnupg.org The C Shore (Daniel Dickinson's Website) http://www.bmts.com/~cshore
signature.asc
Description: PGP signature
_______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
